Use correct settings object for modules imported in workers #9541
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenic
reviewed
Jul 21, 2023
There was a problem hiding this comment.
In an attempt to provide better review than before, I traced everything through, and it all looks good. (Modulo the easily-fixed bug.) We'll see if I was on track!
(I event spent ~10 minutes being confused about whether settingsObject would be correct in HostLoadImportedModule, before I realized it gets fixed in step 6.2.)
|
Thanks for the review! Maybe we should add a note in HostLoadImportedModule explaining fetchClient/settingsObject? |
domenic
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9535
Now modules are created with their referrer's settings object, and fetched with the fetchClient used when starting the graph loading process.